Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 18317 multi move get all moves endpoint #11862

Merged
merged 15 commits into from
Feb 22, 2024

Conversation

TevinAdams
Copy link
Contributor

@TevinAdams TevinAdams commented Jan 26, 2024

Agility ticket

Integration PR

Summary

This story introduces a new endpoint on the internal API to retrieve all moves for a service member. The moves are returned in a json object with structure {currentMove: [{}], previousMoves: [{}]}

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Create a service member and go through the process of requesting a move.
  2. Approve the move as a counselor and approve the move as a TOO
  3. Add shipments to the move as a prime user
  4. Through Postman or swagger send a request to the /all_moves{serviceMemberId} endpoint of the internalAPI
  5. You should get a response with an JSON object {currentMove: [{}], previousMoves: [{}]}. currentMove will have one move in it representing the move with the latest CreatedAt DateTime. PreviousMoves will have all other moves.
  6. To test previous moves make sure the service member has more than one move

Backend

Screenshots

imageimage

@TevinAdams TevinAdams marked this pull request as draft January 26, 2024 02:47
@TevinAdams TevinAdams marked this pull request as ready for review January 26, 2024 02:52
@TevinAdams TevinAdams marked this pull request as draft January 26, 2024 12:27
@TevinAdams TevinAdams closed this Feb 5, 2024
@TevinAdams TevinAdams reopened this Feb 22, 2024
@TevinAdams TevinAdams marked this pull request as ready for review February 22, 2024 16:49
@TevinAdams TevinAdams requested a review from a team as a code owner February 22, 2024 16:49
@TevinAdams TevinAdams added Mountain Movers Movin' Mountains 1 Sprint at a time MAIN labels Feb 22, 2024
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks!

@TevinAdams
Copy link
Contributor Author

Looks good now. Thanks!

Yeah should not happen anymore as absolutely no changes will be made on INT branches.

@deandreJones deandreJones merged commit 88c3df2 into main Feb 22, 2024
38 checks passed
@deandreJones deandreJones deleted the B-18317-MultiMove-getAllMoves-Endpoint branch February 22, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAIN Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

5 participants